fix: js_array and js_array2 wrong return type for from method #4597
+38
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@illusionalsagacity this looks good to me. Would you do a rebase? |
BREAKING CHANGE: return type of js_array.from and js_array2.from has changed Signed-off-by: Rob Meyer <rob@tenex.dev>
illusionalsagacity
force-pushed
the
fix-js-array-from
branch
from
b8bc21a to
7280280
Compare
Sure, there you go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change due to the return type change
Let me know if I need to adjust anything, not too familiar with the PR process for bucklescript but I think I followed the contributing guide.
fixes #3272